-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create images dynamically #15
base: master
Are you sure you want to change the base?
Conversation
So it's "build on release" vs "build on runtime"? Also paging @wyrzyk as the primary author of this module 😉 |
There's next to no difference - you either download the image or build it locally, so it's very similar in terms of performance. |
It was optimised to build the image once and then benefit from a faster and more stable dev loop. Maybe it's possible to support both approaches? 🤔 |
But locally you download it once. |
And you build it only once too, all subsequent runs come from cache. |
I get the build once part, caching is a feature of building itself. |
There's no upload. We don't really need to upload it. |
Ok, so without upload, it will not download at all correct? I'm confused because:
and
|
I was talking about the data needed to build the image. |
Ok, so it's clear. So "after" could be slower than "before", that's why I asked for the difference.
Was it assumed or tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see the duration of SshUbuntuContainer.start
on CI: before/after.
- duration on CI: before/after
What do you think about this approach? We won't be dependent on upstream image updates, we will use official images and we get support for multiple ubuntu releases for free.
If you think it's a good idea, I'll rip out the support for docker image building, it's no longer needed.